Remove nix from the public API #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes nix from the public API. nix has frequent breaking changes due to the large API surface it covers, which makes it a semver hazard to keep it in the public API. Thus far only two items from nix are exposed: Signal and siginfo. Signal is an enum consisting of most real-life Unix signals. I have replaced it with a hand rolled enum primarily taken from the one in async-signal. For the other case, the Event structure exposes most of the relevant fields. So I've turned these fields into accessors. We can PR more later. This is a breaking change, but it's in service of avoiding breaking changes in the future. Closes #179 Signed-off-by: John Nunley <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 14 14
Lines 1858 1858
=======================================
Hits 1586 1586
Misses 272 272 ☔ View full report in Codecov by Sentry. |
Signed-off-by: John Nunley <[email protected]>
elinorbgr
approved these changes
Apr 30, 2024
ids1024
approved these changes
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes nix from the public API. nix has frequent breaking
changes due to the large API surface it covers, which makes it a semver
hazard to keep it in the public API.
Thus far only two items from nix are exposed: Signal and siginfo. Signal
is an enum consisting of most real-life Unix signals. I have replaced it
with a hand rolled enum primarily taken from the one in async-signal.
For the other case, the Event structure exposes most of the relevant
fields. So I've turned these fields into accessors. We can PR more
later.
This is a breaking change, but it's in service of avoiding breaking
changes in the future.
Closes #179